Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unary client supports timeout #31

Merged
merged 2 commits into from
Aug 9, 2018
Merged

Unary client supports timeout #31

merged 2 commits into from
Aug 9, 2018

Conversation

gaschler
Copy link
Contributor

@gaschler gaschler commented Aug 9, 2018

ISSUE=#28

pifon2a
pifon2a approved these changes Aug 9, 2018
View reviewed changes
Copy link
Contributor

@pifon2a pifon2a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed offline, let's refactor Reset() function.

@gaschler gaschler merged commit 771af45 into cartographer-project:master Aug 9, 2018
@gaschler gaschler mentioned this pull request Aug 9, 2018
Open
@stevewolter
Copy link
Contributor

Nive work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pifon2a pifon2a pifon2a approved these changes

@stevewolter stevewolter Awaiting requested review from stevewolter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gaschler @stevewolter @pifon2a