Check output stream in pbstream migration tool. (#1416)

Avoids failing silently, e.g. when file permissions are lacking.
cartographer-project · Sep 10, 2018 · 1d20cef · 1d20cef
1 parent 1ddfd9c
commit 1d20cef
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/cartographer/io/internal/pbstream_migrate.cc b/cartographer/io/internal/pbstream_migrate.cc
@@ -48,6 +48,8 @@ int pbstream_migrate(int argc, char** argv) {
             << "\" to new serialization format in \"" << argv[3] << "\"";
   cartographer::io::MigrateStreamFormatToVersion1(&input, &output,
                                                   FLAGS_migrate_grid_format);
+  CHECK(output.Close()) << "Could not write migrated pbstream file to: "
+                        << argv[3];
 
   return EXIT_SUCCESS;
 }

diff --git a/cartographer/io/serialization_format_migration.cc b/cartographer/io/serialization_format_migration.cc
@@ -278,6 +278,7 @@ void SerializeToVersion1Format(
       SerializedData::kFixedFramePoseDataFieldNumber,
       SerializedData::kLandmarkDataFieldNumber};
 
+  LOG(INFO) << "Writing proto stream.";
   output->WriteProto(CreateSerializationHeader());
   for (auto field_index : kFieldSerializationOrder) {
     const auto proto_vector_it = deserialized_data.find(field_index);