-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improve CONTRIBUTING.md and the pull request template. (#1780)
We refer to CONTRIBUTING.md from the PR template now which is now the single place containing all information. Reference to the bot is removed since it is currently not being used. We point contributors to using clang-format. We link to PR and code review best practices now. Signed-off-by: Wolfgang Hess <whess@lyft.com>
- Loading branch information
Showing
2 changed files
with
24 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,2 @@ | ||
Want to contribute? Great! Make sure you've read, understood and considered all | ||
the points below before creating your PR: | ||
|
||
- Keep your PR under 200 lines of code and address a single concern. | ||
- Add unit test(s) and documentation (these do not count toward your 200 lines). | ||
- Adhere to the [Google C++ Style Guide](https://google.github.io/styleguide/cppguide.html). | ||
- Run `ninja test` or `catkin_make_isolated --install --use-ninja --pkg cartographer --make-args test` as appropriate. | ||
- Keep rebasing (or merging) of master branch to a minimum. It triggers Travis | ||
runs for every update which blocks merging of other changes. Our merge bot | ||
will rebase your branch, reformat your source code and merge as the last step | ||
in the review process. | ||
- Please replace this template text with the commit message you want for your | ||
PR. You and/or the reviewer should keep it updated during the course of the | ||
review using the GitHub edit feature. | ||
Want to contribute? Great! Make sure you've read and understood | ||
[CONTRIBUTING.md](https://github.com/cartographer-project/cartographer/blob/master/CONTRIBUTING.md). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters