Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an odometry term in 2D/3D modeled after 2D's consecutive scan term #370

Closed
damonkohler opened this issue Jun 28, 2017 · 3 comments
Closed

Comments

@damonkohler
Copy link
Contributor

In 2D, since we don't tie poses together with IMU reading, we tie poses together by position. That is, from one pose to the next, the position shouldn't change drastically without sufficient evidence.

The same approach could be used to integrate odometry information. That is, relative odometry readings from one position to the next should not be violated without sufficient evidence.

@BrannonKing
Copy link

It sounds like this is the same bug as #242 and #467 and cartographer-project/cartographer_ros#488, or that they have all morphed together as PoseExtrapolator has taken over the odometry->velocity role. PoseExtrapolator::AddImuData is just too sensitive to noise in the odometry data. Most odometry data comes from wheel encoders; they slip and they often aren't regularly periodic. There is some noisy calculus to convert from multiple wheel encoders into a single odometry point. Simulating them (from my experience) isn't noise-free either -- the timing in the simulation tools is lousy.

@SirVer
Copy link
Contributor

SirVer commented Oct 23, 2017

@cschuet @wohe Is this fixed with your recent 2D/3D unification?

damienrg pushed a commit to damienrg/cartographer that referenced this issue Nov 8, 2017
@cschuet
Copy link

cschuet commented Feb 23, 2018

Fixed in #570.

@cschuet cschuet closed this as completed Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants