Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note for ROS users. #1941

Merged
merged 4 commits into from
Jan 5, 2024
Merged

Add note for ROS users. #1941

merged 4 commits into from
Jan 5, 2024

Conversation

kscottz
Copy link
Contributor

@kscottz kscottz commented Dec 8, 2023

On occasion we receive questions about the maintenance status of Cartographer in ROS. This pull request directs ROS Cartographer users to the correct fork and sets expectations about the maintenance of both this project and its forks.

Wyverald and others added 3 commits December 8, 2023 11:37
Signed-off-by: Xùdōng Yáng <wyverald@gmail.com>
Signed-off-by: kscottz <katherineAScott@gmail.com>
Signed-off-by: kscottz <katherineAScott@gmail.com>
Signed-off-by: kscottz <katherineAScott@gmail.com>
@athackst
Copy link

athackst commented Dec 8, 2023

I'm not opposed to this, but I don't have push access to this repository. Maybe @MichaelGrupp can help direct?

@kscottz
Copy link
Contributor Author

kscottz commented Dec 8, 2023

@athackst thanks. I figured I would ping the familiar faces first. I believe I have admin level access but merging is blocked on a review and I am loathe to turn that off.

@athackst
Copy link

athackst commented Dec 8, 2023

I see, I didn't know you had admin rights! That's cool!

One question I have is: Why not just transfer ownership of these repos to ROS? That way folks should get auto-redirected. (or conversely, since you have admin access, add admins to this repo to maintain it here?)

Copy link

@athackst athackst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, doesn't look like I can clear the "review required" hurdle since I don't have write access.

@MichaelGrupp MichaelGrupp self-requested a review December 11, 2023 10:23
@MichaelGrupp
Copy link
Contributor

Thanks for adding the note. I do have write access, but since @wohe was doing most of the maintenance in this repo and is one of the original authors, I'll add him to the review.

A Note for ROS Users
====================

**Cartographer is no longer actively maintained.**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this note really only for ROS users or for everyone? The repository seems unmaintained completly.

@limdor
Copy link

limdor commented Jan 5, 2024

@MichaelGrupp @kscottz @wohe can some of you merge this? It will make life easier to everyone to know that this repository is unmaintained. Thanks

@kscottz
Copy link
Contributor Author

kscottz commented Jan 5, 2024

Alright, let's move on from asking for permission, and start begging for forgiveness. I am going to go ahead and merge this.

@kscottz kscottz merged commit 877157a into master Jan 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants