Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #36: add EIGEN_MAKE_ALIGNED_NEW in many classes #39

Closed

Conversation

catskul
Copy link
Contributor

@catskul catskul commented Oct 6, 2016

fix #36 add EIGEN_MAKE_ALIGNED_NEW in all places found by find ./ -name "*.h*" | xargs grep --color "^[^(]*Eigen::[^(&={]*$"

Probably not exhaustive

Builds and passes all tests.

Will likely have CLA approved by 2016-10-07

…found by `find ./ -name "*.h*" | xargs grep --color "^[^(]*Eigen::[^(&={]*$"`
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@catskul
Copy link
Contributor Author

catskul commented Oct 7, 2016

CLA now signed for Carnegie Robotics

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Oct 7, 2016
@damonkohler
Copy link
Contributor

As discussed and documented in the system requirements, we currently target only 64-bit systems where this is not necessary. I'll close this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Structs and classes containing eigen typed data members missing EIGEN_MAKE_ALIGNED_OPERATOR_NEW
3 participants