Skip to content

Commit

Permalink
Use the MapBuilder factory function. (#1551)
Browse files Browse the repository at this point in the history
This follows cartographer-project/cartographer#1776.

Signed-off-by: Wolfgang Hess <whess@lyft.com>
  • Loading branch information
wohe committed Nov 6, 2020
1 parent b1dde03 commit 2712067
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 9 deletions.
4 changes: 2 additions & 2 deletions cartographer_ros/cartographer_ros/node_main.cc
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ void Run() {
std::tie(node_options, trajectory_options) =
LoadOptions(FLAGS_configuration_directory, FLAGS_configuration_basename);

auto map_builder = absl::make_unique<cartographer::mapping::MapBuilder>(
node_options.map_builder_options);
auto map_builder =
cartographer::mapping::CreateMapBuilder(node_options.map_builder_options);
Node node(node_options, std::move(map_builder), &tf_buffer,
FLAGS_collect_metrics);
if (!FLAGS_load_state_filename.empty()) {
Expand Down
2 changes: 1 addition & 1 deletion cartographer_ros/cartographer_ros/node_options.cc
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
#include <vector>

#include "cartographer/common/configuration_file_resolver.h"
#include "cartographer/mapping/map_builder.h"
#include "cartographer/mapping/map_builder_interface.h"
#include "glog/logging.h"

namespace cartographer_ros {
Expand Down
11 changes: 5 additions & 6 deletions cartographer_ros/cartographer_ros/offline_node_main.cc
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,11 @@ int main(int argc, char** argv) {

cartographer_ros::ScopedRosLogSink ros_log_sink;

const cartographer_ros::MapBuilderFactory map_builder_factory =
[](const ::cartographer::mapping::proto::MapBuilderOptions&
map_builder_options) {
return absl::make_unique< ::cartographer::mapping::MapBuilder>(
map_builder_options);
};
const cartographer_ros::MapBuilderFactory map_builder_factory = [](
const ::cartographer::mapping::proto::MapBuilderOptions&
map_builder_options) {
return ::cartographer::mapping::CreateMapBuilder(map_builder_options);
};

cartographer_ros::RunOfflineNode(map_builder_factory);

Expand Down

0 comments on commit 2712067

Please sign in to comment.