Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that --build-values does not affect package output #1310

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Ensure that --build-values does not affect package output #1310

merged 2 commits into from
Aug 24, 2023

Conversation

100mik
Copy link
Contributor

@100mik 100mik commented Aug 23, 2023 •
edited
Loading

Which issue(s) this PR fixes:

Fixes #1309

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:

@100mik
Ensure that --build-values does not affect package output
d046d26 
Signed-off-by: Soumik Majumder <soumikm@vmware.com>
@100mik
Make --build-values test stricter
4a58d51 
Signed-off-by: Soumik Majumder <soumikm@vmware.com>
praveenrewar
praveenrewar approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@100mik 100mik merged commit 2165849 into carvel-dev:develop Aug 24, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveenrewar praveenrewar praveenrewar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Carvel
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kctrl: --build-values affects outputted package
2 participants
@100mik @praveenrewar