Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move --dangerous-disable-gk-scoping flag to kapp deploy #752

Merged
merged 1 commit into from
May 12, 2023
Merged

move --dangerous-disable-gk-scoping flag to kapp deploy #752

merged 1 commit into from
May 12, 2023

Conversation

hernandanielg
Copy link
Contributor

What this PR does / why we need it:

Move --dangerous-disable-gk-scoping flag to be only available in kapp deploy

Which issue(s) this PR fixes:

Fixes #750

Does this PR introduce a user-facing change?


Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:


Signed-off-by: Hernan Garcia <hernan.garcia@percona.com>
Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you so much for the contribution!!

@praveenrewar praveenrewar merged commit 3e2edfa into carvel-dev:develop May 12, 2023
5 checks passed
@hernandanielg hernandanielg deleted the move-disable-gk-flag-to-deploy branch May 12, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

--dangerous-disable-gk-scoping should only be available in kapp deploy
2 participants