Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi-arch builds in dockerfile #59

Closed
wants to merge 1 commit into from
Closed

Support multi-arch builds in dockerfile #59

wants to merge 1 commit into from

Conversation

joshrosso
Copy link

built using:

docker buildx build --push -t joshrosso/secretgen-controller --platform linux/arm64,linux/amd64 .

Image available at:

docker.io/joshrosso/secretgen-controller:latest

manifest resulting in:

{
  "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
  "schemaVersion": 2,
  "manifests": [
    {
      "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
      "digest": "sha256:118e3346384cdede1d09bea86afb85ec195cc036a1d13fc89d6369230f1b4ff2",
      "size": 1370,
      "platform": {
        "architecture": "arm64",
        "os": "linux"
      }
    },
    {
      "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
      "digest": "sha256:cefcae98b52e1f09394cfcdf2370a727c7e33d4e652488f3d06460035e8f49f5",
      "size": 1370,
      "platform": {
        "architecture": "amd64",
        "os": "linux"
      }
    }
  ]
}

resolves: #57

Let me know if you'd like to take another approach.

Signed-off-by: joshrosso <rossoj@vmware.com>
@joe-kimmel-vmw
Copy link
Contributor

Thanks @joshrosso - I know it's a little invisible but we've been talking about how best to support ARM builds here and in kapp-controller. @benmoss was exploring a different approach to organizing our checksums this morning. Appreciate your persistence and patience as we figure out how to balance our priorities.

@benmoss
Copy link
Contributor

benmoss commented Apr 7, 2022

Similar comment to carvel-dev/kapp-controller#574 (comment), can you set defaults for TARGETOS/TARGETARCH so we can roll this out iteratively?

@cppforlife
Copy link
Contributor

covered by #85

@cppforlife cppforlife closed this Jul 7, 2022
@github-actions github-actions bot added the carvel-triage This issue has not yet been reviewed for validity label Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel-triage This issue has not yet been reviewed for validity cla-not-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create arm64 image for secretgen-controller
5 participants