-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create linux-arm64 builds of kapp-controller
#574
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking as a draft since it's not ready to be merged yet. These ? lines are I think just merge mistakes.
What about using docker buildx for multi-platform images? I wish we could use ko, but our heavy dependency on binaries makes it difficult.
I'll address the merge issues.
This PR makes changes required to use |
Signed-off-by: joshrosso <joshrosso@gmail.com>
My bad, early morning reading comprehension is not at peak performance |
All good, I feel your pain. Let me know if you have suggested approaches for checksum resolution. These changes make the Dockerfile a bit ugly, i'm happy to add alternative approaches. On the flip-side, this approach is pretty "clear" (ie not clever) in what it's doing IMO. |
i think this will also break our dev deploy script. it might even be an invitation to revisit the assumptions made by that script. The valuable part of that script is that it builds the executable on the developer's local system which has a ton of cached build artifacts, which saves us a few minutes during that "inner loop" iteration process, but obviously isn't hermetic the way you'd want for proper testing & releasing. The rest of that script is just a particular implementation of how to get there. I can take a look at it later in the week. |
I see that. I can add architecture detection to that script, as right now it's failing outside of the context of I'm happy to do any work, just want guidance from this team as I don't know how "smart" you want something like this script to become. |
I don't think we need to update I'm also happy to take this PR over if you want |
Closing in favor of #680, apologies for the delay on this |
This PR requires:
to be resolved. For now, I am referencing arm64 binaries of
vendir
andimgpkg
I have built.Using this Dockerfile, multi-arch images can be built using:
I've pushed a
projects.registry.vmware.com/tce/kapp-controller-multi:v0.30.1
to test. It works for me, on a kind cluster running on arm64.Resolves: #573