Feature Ignore Paths

[joelholmes]

Issue: #37

Created a function that will copy existing files listed in the destination directory to the staging area prior to deletion preserving the content. I felt that pulling the content into the staging area was simple compared to making the Replace function more complicated. Also I felt that the issue described only keeping the specified files where the alternative solution would keep untracked files around.

Testing seemed a little tricky and am open to suggestions for a separate test. Essentially I changed a value in a file and rely on the examples tests.

[vmwclabot]

@joelholmes, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

[jhosteny]

@joelholmes just making a note that I believe this works with your PR if you make the following change to the example:

apiVersion: vendir.k14s.io/v1alpha1
kind: Config
directories:
- path: components/terraform
  contents:
  - path: account-map
    git:
      url: https://github.com/cloudposse/terraform-aws-components
      ref: 0.137.0
    newRootPath: modules/account-map
    includePaths:
      - modules/account-map/**/*
    ignorePaths: &ignore
    - account-map/backend.tf.json

Note that the ignorePaths glob has the account-map in the path. Instead, I think this should assume that it is rooted in the destination directory (i.e., ./components/terraform/account-map), so that the provided example would work. Perhaps @aknysh can confirm?

[joelholmes]

I was able to get this to work with the relative path and have updated the code.

[cppforlife]

will try to take a look at this PR this coming week.

[cppforlife]

first pass review.

[cppforlife]

im still chewing on this line. will play around more.

[joelholmes]

Great, keep me posted on what you would suggest. I messed around with this a bit and was the best solution I could come up with. Not super happy with the solution.

[vmwclabot]

@joelholmes, your company's legal contact did not review your signed contributor license agreement within the 14 day limit. The merge can not proceed. Click here to resign the agreement.

[joelholmes]

@joelholmes, your company's legal contact did not review your signed contributor license agreement within the 14 day limit. The merge can not proceed. Click here to resign the agreement.

I was able to resign the agreement.

[joelholmes]

Our legal department has not received the CLA email and emails to OSSContributions@vmware.com have bounced. Is there another way or a contact we can reach out to in order to resolve this?

[microwavables]

Our legal department has not received the CLA email and emails to OSSContributions@vmware.com have bounced. Is there another way or a contact we can reach out to in order to resolve this?

Hey Joel, wanted to give you an update to let you know we are working to resolve the issues you are experiencing with the CLA and email. Will let you know as soon as things are resolved.

[aknysh]

@joelholmes just making a note that I believe this works with your PR if you make the following change to the example:

apiVersion: vendir.k14s.io/v1alpha1
kind: Config
directories:
- path: components/terraform
  contents:
  - path: account-map
    git:
      url: https://github.com/cloudposse/terraform-aws-components
      ref: 0.137.0
    newRootPath: modules/account-map
    includePaths:
      - modules/account-map/**/*
    ignorePaths: &ignore
    - account-map/backend.tf.json

Note that the ignorePaths glob has the account-map in the path. Instead, I think this should assume that it is rooted in the destination directory (i.e., ./components/terraform/account-map), so that the provided example would work. Perhaps @aknysh can confirm?

I think both ways are OK, but
ignorePaths has a diff behavior than includePaths.
includePaths define the source paths, while ignorePaths works with the destination paths.
And since we already define the destination folder in - path: account-map, then I think there is no need to use the same folder account-map in ignorePaths

[microwavables]

Our legal department has not received the CLA email and emails to OSSContributions@vmware.com have bounced. Is there another way or a contact we can reach out to in order to resolve this?

Hey Joel, wanted to give you an update to let you know we are working to resolve the issues you are experiencing with the CLA and email. Will let you know as soon as things are resolved.

@joelholmes my sources tell me to advise you to try oss.contributions.vmware@vmware.com as an alternate email while we investigate what's going on with osscontributions@vmware.com.

[vmwclabot]

@joelholmes, your company's legal contact has approved your signed contributor license agreement. It will also be reviewed by VMware, but the merge can proceed.

[vmwclabot]

@joelholmes, VMware has approved your signed contributor license agreement.

[osterman]

Anxiously awaiting approval and merge =)

[osterman]

@cppforlife is this good to go?