Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support ignorePaths to exclude removal of certain files #37

Closed
cppforlife opened this issue Jan 6, 2021 · 3 comments
Closed

support ignorePaths to exclude removal of certain files #37

cppforlife opened this issue Jan 6, 2021 · 3 comments
Labels
carvel-accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request

Comments

@cppforlife
Copy link
Contributor

Describe the problem/challenge you have

in some cases it's useful to retain certain temp files among fetched directories. (e.g. temp files generated by tools that were operating on top of fetched files.)

Describe the solution you'd like

add ignorePaths key on directory contents. ignorePaths would specify a set of globs that would be used to match in existing directories and copy them over on top of newly fetched sources.

apiVersion: vendir.k14s.io/v1alpha1
kind: Config
directories:
- path: components/terraform
  contents:
  - path: account-map
    git:
      url: https://github.com/cloudposse/terraform-aws-components
      ref: 0.137.0
    newRootPath: modules/account-map
    includePaths:
      - modules/account-map/**/*
    ignorePaths: &ignore
    - backend.tf.json
    - catalog/*

  - path: account-settings
    git:
      url: https://github.com/cloudposse/terraform-aws-components
      ref: 0.137.0
    newRootPath: modules/account-settings
    includePaths:
      - modules/account-settings/**/*
    ignorePaths: *ignore

Details:

  • for directories that have been removed in newly fetched content, ignored content wont be retained
  • files that already exist in newly fetched content will take precedence over files that copied from original directory.
@cppforlife cppforlife added enhancement This issue is a feature request carvel-triage This issue has not yet been reviewed for validity labels Jan 6, 2021
@aknysh
Copy link
Contributor

aknysh commented Jan 6, 2021

@cppforlife thank you.
The description sounds like what we need.

@cppforlife cppforlife added carvel-accepted This issue should be considered for future work and that the triage process has been completed and removed carvel-triage This issue has not yet been reviewed for validity labels Jan 8, 2021
@aaronshurley
Copy link
Contributor

Thanks for submitting this. We may not get to this soon but would accept contributions :)

@ewrenn8
Copy link
Contributor

ewrenn8 commented Jun 23, 2021

included in v0.20.0

@ewrenn8 ewrenn8 closed this as completed Jun 23, 2021
@github-actions github-actions bot added carvel-triage This issue has not yet been reviewed for validity and removed carvel-triage This issue has not yet been reviewed for validity labels Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel-accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request
Projects
None yet
Development

No branches or pull requests

4 participants