Do not assign the patched speak function to None #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce the issue
Result
NVDA cannot speak anymore
Probable explanation
When multiple add-ons patch
speech.speak
, we cannot consider that we have a reliable order to ensure that add-on 1 patches first and unpatch last with respect to add-on 2.Solution
Do not set the patch function variable to
None
. when therminating the add-on.We probably end up with not all speak functions being unpatched, but that still much better than having an error on each speak call.
Note
With NVDA 2024.2, there will be an extension point for the speak function which will be much cleaner.