Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not assign the patched speak function to None #14

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Do not assign the patched speak function to None #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion addon/globalPlugins/clipboardEnhancement/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,7 +737,11 @@ def terminate(self):
self.monitor.Stop()
self.monitor = None
speechModule.speak = self.oldSpeak
self.oldSpeak = None
# Do not set self.oldSpeak to None.
# Since many add-ons can patch speech.speak and since the order in which patching and unpatching is not
# well established, we may end up speech.speak restored to None (e.g. clipboardEnhancement and
# baiduTranslation)
# self.oldSpeak = None
if self.editor:
cary-rowen marked this conversation as resolved.
Show resolved Hide resolved
self.editor.isExit = True
self.editor.Destroy()
Expand Down