Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selector doesn't drag corner past opposite corner #1

Closed
DarthGandalf opened this issue Jul 31, 2020 · 9 comments
Closed

Selector doesn't drag corner past opposite corner #1

DarthGandalf opened this issue Jul 31, 2020 · 9 comments

Comments

@DarthGandalf
Copy link
Collaborator

It just pushes the whole selected rectangle (which is now a single line or even a point) further

@carygravel
Copy link
Owner

On a bionic-based system, it is working for me, without my having done anything to fix it, as is the Gscan2pdf::ImageView version. I'll test my Debian testing based system next.

@DarthGandalf
Copy link
Collaborator Author

It was you who noticed the issue at all. What system that was on?

But I confirm this behavior on Gentoo

@carygravel
Copy link
Owner

Just committed a fix for this.

@carygravel
Copy link
Owner

Is it time for a new release?

Or is there something you'd like to get in in the next couple of days?

@DarthGandalf
Copy link
Collaborator Author

Tip: you could use "Closes #1" in commit message to close the issue automatically, and that would also link the commit here.

Sure, let's release. I wanted to do it some time ~soon anyway, to get #16 in.

@DarthGandalf
Copy link
Collaborator Author

You forgot to push the master branch with v6

@carygravel
Copy link
Owner

You're right that Github hadn't registered it, but I did push it, with git push --tags, which on other repo pushes the commits, plus the tags. Github seems to need to have the commits first, and the tags afterwards in a second operation.

@DarthGandalf
Copy link
Collaborator Author

I think this is not specific to Github, but because of git push --tags. git push --tags master would push both in a single operation.
Also, from man git-push:

When neither the command-line nor the configuration specify what to push, the default behavior is used, which corresponds to the simple value for push.default

Probably that's why it worked for you with 2 commands git push --tags; git push without explicitly mentioning master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants