Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSFits: non-constant receptor angles in MS FEED table prevent export to UV FITS #1340

Closed
dpetry opened this issue Mar 25, 2024 · 4 comments · Fixed by #1341
Closed

MSFits: non-constant receptor angles in MS FEED table prevent export to UV FITS #1340

dpetry opened this issue Mar 25, 2024 · 4 comments · Fixed by #1341
Assignees

Comments

@dpetry
Copy link
Contributor

dpetry commented Mar 25, 2024

In an ALMA helpdesk ticket, a user reported a case where an MS contained non-constant receptor angles in the FEED table and could therefore not be exported.
These angles are only relevant for calibration. If the date is already calibrated, which is usually the case before export to UV FITS, the angles are irrelevant.
I propose to relax the conditions of the code and make it only produce a warning when non-constant (in time) receptor angles are encountered.

@dpetry dpetry self-assigned this Mar 25, 2024
@dpetry
Copy link
Contributor Author

dpetry commented Mar 25, 2024

@tammojan , I have a new version of msfits/MSFits/MSFitsOutput.cc which fixes this issue. How should I go about bringing it in?
(Haven't done a casacore change for some time.)

@tammojan
Copy link
Contributor

You could make a branch, put the file in that, push the branch, which will give you a link to make a pull request. But if you want you can also send the file to me and I'll make a pull request for you.

@dpetry
Copy link
Contributor Author

dpetry commented Mar 25, 2024

OK, I will send you the file by email. I don't have time to work out the technical details of the forking etc. at the moment.
But I have compiled and tested the code with my local CASA developer build.

@dpetry
Copy link
Contributor Author

dpetry commented Mar 25, 2024

P.S.: I created a branch using the link on the issue page, but I don't know if this is useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants