-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSFits: non-constant receptor angles in MS FEED table prevent export to UV FITS #1340
Comments
@tammojan , I have a new version of msfits/MSFits/MSFitsOutput.cc which fixes this issue. How should I go about bringing it in? |
You could make a branch, put the file in that, push the branch, which will give you a link to make a pull request. But if you want you can also send the file to me and I'll make a pull request for you. |
OK, I will send you the file by email. I don't have time to work out the technical details of the forking etc. at the moment. |
P.S.: I created a branch using the link on the issue page, but I don't know if this is useful. |
Implemented by Dirk Petry Fixes #1340
In an ALMA helpdesk ticket, a user reported a case where an MS contained non-constant receptor angles in the FEED table and could therefore not be exported.
These angles are only relevant for calibration. If the date is already calibrated, which is usually the case before export to UV FITS, the angles are irrelevant.
I propose to relax the conditions of the code and make it only produce a warning when non-constant (in time) receptor angles are encountered.
The text was updated successfully, but these errors were encountered: