Modernised matrix syntax in FITS files now following standard 3.0: #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Format is now XXi_j. No leading zeros in indices.
tammojan
reviewed
Jun 23, 2017
| << setfill('0') << setw(2) << jj; | ||
| name += String(ostr); | ||
| ostringstream ostr; | ||
| if(nrow>9){ |
There was a problem hiding this comment.
Does this magic number 9 mean something? If so, could you put a comment here?
There was a problem hiding this comment.
It's simply the transition from a one-digit to a two-digit decimal integer.
There was a problem hiding this comment.
I mean the integer for the indices of the matrix.
|
Any objections to me merging this pull request? |
|
I'm no FITS expert, but the changes look straightforward enough, and seem OK to me. As for magic number, I usually prefer not to have them; in this case, it's fairly clear what the meaning is, but a comment surely wouldn't hurt for the benefit of the next person to look at the code. |
|
OK, will do in the second instalment of my work on CAS-9993 . Promise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Format is now XXi_j. No leading zeros in indices.
This is part 1 of 2 for a fix to CAS-9993 which reports general problems with the PC matrix
in cases where the matrix is non-diagonal.