-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build casacore 3.5.0 #9
Open
ludwigschwardt
wants to merge
8
commits into
master
Choose a base branch
from
casacore-3.5.0
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use latest stable version from GitHub. The new Dysco storage manager needs GSL, and Python 2 support is now disabled by default.
We need a new stable version every two months...
Since we don't install the Python 2 bindings (called "python") anymore, it is safe to remove patches to that part of the code. Replace the old patch with a fix to the Dysco tests which was recently added to the development version in casacore/casacore#1350. This should be removed when we move to the next casacore release.
We almost always want Python bindings. Rather disable Python explicitly with `--without-python` in case you don't.
This is mostly to advertise the git replace mechanism used to link the older (ska-sa) commits before 2021 to the latest casacore project ones. This step (done per cloned local repository) allows `git log`, `git blame` and other commands to treat the two disparate histories as one. For the record, I followed these instructions: https://steemit.com/git/@sushrest/merging-2-repositories-to-preserve-history-using-grafting
I ran `brew tap-new --no-git test/tap` to get the latest GitHub workflows and copied the template over the existing ones. I might as well mention brew bundles in the README as well.
The tests pass again and we have bottles :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
casacore-data
measures, for what it's worth.