-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build casacore 3.5.0 on macOS #9
Merged
Merged
Commits on Jun 11, 2024
-
Use latest stable version from GitHub. The new Dysco storage manager needs GSL, and Python 2 support is now disabled by default.
Configuration menu - View commit details
-
Copy full SHA for f8a6815 - Browse repository at this point
Copy the full SHA f8a6815View commit details
Commits on Jun 12, 2024
-
We need a new stable version every two months...
Configuration menu - View commit details
-
Copy full SHA for e2bad2d - Browse repository at this point
Copy the full SHA e2bad2dView commit details -
casacore: Remove Python 2 patch and add #1350 fix
Since we don't install the Python 2 bindings (called "python") anymore, it is safe to remove patches to that part of the code. Replace the old patch with a fix to the Dysco tests which was recently added to the development version in casacore/casacore#1350. This should be removed when we move to the next casacore release.
Configuration menu - View commit details
-
Copy full SHA for ac4c76b - Browse repository at this point
Copy the full SHA ac4c76bView commit details -
casacore: Build Python bindings by default
We almost always want Python bindings. Rather disable Python explicitly with `--without-python` in case you don't.
Configuration menu - View commit details
-
Copy full SHA for ae8ed6d - Browse repository at this point
Copy the full SHA ae8ed6dView commit details -
This is mostly to advertise the git replace mechanism used to link the older (ska-sa) commits before 2021 to the latest casacore project ones. This step (done per cloned local repository) allows `git log`, `git blame` and other commands to treat the two disparate histories as one. For the record, I followed these instructions: https://steemit.com/git/@sushrest/merging-2-repositories-to-preserve-history-using-grafting
Configuration menu - View commit details
-
Copy full SHA for 4dfa6a9 - Browse repository at this point
Copy the full SHA 4dfa6a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd803c5 - Browse repository at this point
Copy the full SHA bd803c5View commit details -
Update to latest Homebrew tap actions
I ran `brew tap-new --no-git test/tap` to get the latest GitHub workflows and copied the template over the existing ones. I might as well mention brew bundles in the README as well.
Configuration menu - View commit details
-
Copy full SHA for 88ae5a5 - Browse repository at this point
Copy the full SHA 88ae5a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 88bdf17 - Browse repository at this point
Copy the full SHA 88bdf17View commit details
Commits on Jun 20, 2024
-
Use master branch in GitHub Actions (for now)
Ideally I would have liked to rename master branch to main instead, but this is in the midst of a PR with an open branch and it would therefore have been messy.
Configuration menu - View commit details
-
Copy full SHA for 7ddba91 - Browse repository at this point
Copy the full SHA 7ddba91View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.