Added tests for tables

[shibasisp]

Added tests for tables.

[shibasisp]

I haven't touched test_images.py, yet it's showing error for that one. I can't figure out the reason.
And the 2nd error for msutil, I have changed in my another PR.

[tammojan]

And the 2nd error for msutil, I have changed in my another PR.

Could you help a bit and give the number of that PR?

[shibasisp]

Apology for submitting the PR late. Now, I have submitted the PR and it's #98 .

[tammojan]

The tests here fail due to use of has_key, which you have fixed in #98. So we should merge #98 first to get a green test result here.

[coveralls]

Coverage decreased (-2.0%) to 51.955% when pulling a512506 on shibasisp:test_table into 00fb70f on casacore:master.

[tammojan]

The tests fail on the issue that was fixed in #98, so that should be fixed when merging to master.

@shibasisp , do you know why coverage decreased? You've added many new tests, so I'd say the coverage should increase.

[pep8speaks]

Hello @shibasisp! Thanks for updating the PR.

• In the file casacore/functionals/functional.py, following are the PEP8 issues :

Line 43:5: E129 visually indented line with same indent as next logical line
Line 56:1: W293 blank line contains whitespace
Line 269:80: E501 line too long (80 > 79 characters)
Line 330:80: E501 line too long (87 > 79 characters)

• In the file casacore/images/image.py, following are the PEP8 issues :

Line 85:80: E501 line too long (80 > 79 characters)
Line 159:25: E722 do not use bare except'
Line 160:80: E501 line too long (81 > 79 characters)
Line 249:80: E501 line too long (90 > 79 characters)
Line 499:80: E501 line too long (80 > 79 characters)
Line 512:80: E501 line too long (80 > 79 characters)
Line 529:80: E501 line too long (80 > 79 characters)
Line 604:80: E501 line too long (82 > 79 characters)
Line 609:80: E501 line too long (81 > 79 characters)

• In the file casacore/tables/msutil.py, following are the PEP8 issues :

Line 52:80: E501 line too long (81 > 79 characters)
Line 66:5: E722 do not use bare except'
Line 74:5: E722 do not use bare except'
Line 78:80: E501 line too long (88 > 79 characters)
Line 79:80: E501 line too long (80 > 79 characters)
Line 110:80: E501 line too long (85 > 79 characters)
Line 287:80: E501 line too long (81 > 79 characters)
Line 306:80: E501 line too long (82 > 79 characters)
Line 307:80: E501 line too long (82 > 79 characters)
Line 388:80: E501 line too long (91 > 79 characters)
Line 421:80: E501 line too long (80 > 79 characters)

• In the file casacore/tables/table.py, following are the PEP8 issues :

Line 51:1: E302 expected 2 blank lines, found 1
Line 52:3: E111 indentation is not a multiple of four
Line 58:80: E501 line too long (80 > 79 characters)
Line 61:3: E114 indentation is not a multiple of four (comment)
Line 62:3: E111 indentation is not a multiple of four
Line 65:3: E111 indentation is not a multiple of four
Line 68:3: E114 indentation is not a multiple of four (comment)
Line 69:3: E111 indentation is not a multiple of four
Line 71:1: E302 expected 2 blank lines, found 1
Line 72:3: E111 indentation is not a multiple of four
Line 84:3: E111 indentation is not a multiple of four
Line 87:3: E114 indentation is not a multiple of four (comment)
Line 88:3: E111 indentation is not a multiple of four
Line 91:3: E111 indentation is not a multiple of four
Line 94:3: E114 indentation is not a multiple of four (comment)
Line 95:3: E111 indentation is not a multiple of four
Line 98:1: E302 expected 2 blank lines, found 1
Line 118:80: E501 line too long (80 > 79 characters)
Line 143:80: E501 line too long (81 > 79 characters)
Line 144:5: E722 do not use bare except'
Line 194:80: E501 line too long (82 > 79 characters)
Line 348:80: E501 line too long (108 > 79 characters)
Line 365:80: E501 line too long (119 > 79 characters)
Line 366:80: E501 line too long (82 > 79 characters)
Line 369:80: E501 line too long (80 > 79 characters)
Line 371:80: E501 line too long (118 > 79 characters)
Line 372:80: E501 line too long (96 > 79 characters)
Line 377:80: E501 line too long (112 > 79 characters)
Line 398:16: E127 continuation line over-indented for visual indent
Line 398:80: E501 line too long (80 > 79 characters)
Line 426:9: E722 do not use bare except'
Line 435:17: E722 do not use bare except'
Line 438:9: E722 do not use bare except'
Line 457:80: E501 line too long (82 > 79 characters)
Line 609:80: E501 line too long (80 > 79 characters)
Line 688:80: E501 line too long (89 > 79 characters)
Line 737:80: E501 line too long (80 > 79 characters)
Line 815:80: E501 line too long (81 > 79 characters)
Line 910:45: E703 statement ends with a semicolon
Line 916:80: E501 line too long (80 > 79 characters)
Line 947:80: E501 line too long (85 > 79 characters)
Line 955:80: E501 line too long (80 > 79 characters)
Line 973:80: E501 line too long (80 > 79 characters)
Line 981:80: E501 line too long (85 > 79 characters)
Line 1023:80: E501 line too long (85 > 79 characters)
Line 1029:80: E501 line too long (80 > 79 characters)
Line 1040:80: E501 line too long (83 > 79 characters)
Line 1058:80: E501 line too long (83 > 79 characters)
Line 1067:80: E501 line too long (85 > 79 characters)
Line 1099:80: E501 line too long (80 > 79 characters)
Line 1105:80: E501 line too long (83 > 79 characters)
Line 1214:80: E501 line too long (80 > 79 characters)
Line 1239:80: E501 line too long (86 > 79 characters)
Line 1282:76: W291 trailing whitespace
Line 1283:80: E501 line too long (82 > 79 characters)
Line 1285:80: E501 line too long (83 > 79 characters)
Line 1348:80: E501 line too long (83 > 79 characters)
Line 1448:11: E111 indentation is not a multiple of four
Line 1450:11: E111 indentation is not a multiple of four
Line 1469:80: E501 line too long (80 > 79 characters)
Line 1479:80: E501 line too long (80 > 79 characters)
Line 1496:80: E501 line too long (80 > 79 characters)
Line 1498:80: E501 line too long (80 > 79 characters)
Line 1516:80: E501 line too long (80 > 79 characters)
Line 1619:80: E501 line too long (80 > 79 characters)
Line 1649:80: E501 line too long (85 > 79 characters)
Line 1650:80: E501 line too long (115 > 79 characters)
Line 1809:80: E501 line too long (80 > 79 characters)
Line 1810:80: E501 line too long (92 > 79 characters)
Line 1847:80: E501 line too long (81 > 79 characters)
Line 1872:80: E501 line too long (90 > 79 characters)
Line 1881:80: E501 line too long (81 > 79 characters)
Line 1890:80: E501 line too long (108 > 79 characters)
Line 1892:80: E501 line too long (84 > 79 characters)
Line 1893:80: E501 line too long (95 > 79 characters)

• In the file casacore/tables/tablecolumn.py, following are the PEP8 issues :

Line 59:80: E501 line too long (88 > 79 characters)
Line 148:80: E501 line too long (92 > 79 characters)
Line 158:80: E501 line too long (82 > 79 characters)
Line 168:80: E501 line too long (82 > 79 characters)
Line 170:80: E501 line too long (83 > 79 characters)
Line 173:80: E501 line too long (99 > 79 characters)
Line 197:80: E501 line too long (85 > 79 characters)
Line 238:80: E501 line too long (81 > 79 characters)
Line 255:17: E722 do not use bare except'
Line 258:9: E722 do not use bare except'

• In the file casacore/tables/tablehelper.py, following are the PEP8 issues :

Line 35:80: E501 line too long (83 > 79 characters)
Line 61:5: E722 do not use bare except'

• In the file casacore/tables/tableindex.py, following are the PEP8 issues :

Line 82:80: E501 line too long (92 > 79 characters)
Line 176:30: E703 statement ends with a semicolon

• In the file casacore/tables/tableutil.py, following are the PEP8 issues :

Line 168:80: E501 line too long (80 > 79 characters)
Line 263:80: E501 line too long (80 > 79 characters)
Line 273:80: E501 line too long (80 > 79 characters)
Line 298:80: E501 line too long (81 > 79 characters)
Line 337:80: E501 line too long (80 > 79 characters)
Line 343:80: E501 line too long (80 > 79 characters)
Line 372:80: E501 line too long (80 > 79 characters)
Line 428:80: E501 line too long (80 > 79 characters)
Line 481:80: E501 line too long (94 > 79 characters)
Line 485:1: E302 expected 2 blank lines, found 1
Line 486:3: E111 indentation is not a multiple of four
Line 488:80: E501 line too long (80 > 79 characters)
Line 489:80: E501 line too long (81 > 79 characters)
Line 509:3: E111 indentation is not a multiple of four
Line 512:3: E111 indentation is not a multiple of four
Line 517:7: E111 indentation is not a multiple of four
Line 518:7: E111 indentation is not a multiple of four
Line 519:7: E111 indentation is not a multiple of four
Line 521:3: E111 indentation is not a multiple of four
Line 523:3: E114 indentation is not a multiple of four (comment)
Line 524:3: E114 indentation is not a multiple of four (comment)
Line 525:3: E111 indentation is not a multiple of four
Line 527:7: E111 indentation is not a multiple of four
Line 535:7: E111 indentation is not a multiple of four
Line 538:7: E111 indentation is not a multiple of four
Line 548:7: E111 indentation is not a multiple of four
Line 552:7: E111 indentation is not a multiple of four
Line 554:7: E111 indentation is not a multiple of four
Line 555:25: E127 continuation line over-indented for visual indent
Line 557:29: E127 continuation line over-indented for visual indent
Line 559:3: E114 indentation is not a multiple of four (comment)
Line 560:3: E111 indentation is not a multiple of four
Line 561:10: E228 missing whitespace around modulo operator
Line 565:13: E203 whitespace before ':'
Line 572:1: E305 expected 2 blank lines after class or function definition, found 1
Line 661:5: E722 do not use bare except'
Line 672:5: E722 do not use bare except'

• In the file tests/test_functionals.py, following are the PEP8 issues :

Line 44:80: E501 line too long (82 > 79 characters)
Line 135:80: E501 line too long (80 > 79 characters)
Line 168:80: E501 line too long (80 > 79 characters)
Line 201:80: E501 line too long (80 > 79 characters)
Line 258:5: E301 expected 1 blank line, found 0
Line 273:80: E501 line too long (80 > 79 characters)
Line 278:1: W391 blank line at end of file

• In the file tests/test_image.py, following are the PEP8 issues :

Line 195:14: E211 whitespace before '('

• In the file tests/test_table.py, following are the PEP8 issues :

Line 619:80: E501 line too long (80 > 79 characters)

[coveralls]

Coverage increased (+9.8%) to 63.693% when pulling 1a20c54 on shibasisp:test_table into 00fb70f on casacore:master.