-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add GetDomainsForUser API #161
Conversation
@thoraj plz review. |
Signed-off-by: Sagilio <Sagilio@outlook.com>
I will be happy to review. Is there a nuget feed where I can pick up the build? |
@sagilio is there a nightly nuget feed for this PR, which can be used for testing? |
@hsluoyz Secrets are not passed to workflows that are triggered by a pull request from a fork. Pushing myget packages needs the |
I have changed the CI. We can merge first, It will release on MyGet feed. |
feat: Add GetDomainsForUser API
Signed-off-by: Sagilio <Sagilio@outlook.com>
@hsluoyz So, I try to split the |
@sagilio I didn't see a new release coming after this PR merge. We still should do this: Let's say the latest version is v1.2.2. When we have new PR:
|
@hsluoyz We can not release to MyGet from fork repo. Now, the release policy like this. it only added one more confirmation after merge:
I think this is a better way for this repo. In fact, it more like the build pipeline and release pipeline in Azure DevOps. |
@sagilio how to trigger semantic release for me? |
I noticed there was a new package v1.8.0 on nuget so I ran some test on that. I got the expected results so LGTM. I only tested providing a user parameter like this. domains = enforcer.GetDomainsForUser("@user1"); I did not provide anything for the roleType, as I'm not sure what to expect for these cases. |
@thoraj It will use the default role type.
|
Fixes: #147
Can not update
DynamicExpresso.Core
to v2.5.0: dynamicexpresso/DynamicExpresso#144