chore: Util cleanup #124
Merged
chore: Util cleanup #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yash Pandey (YP) <yash.btech.cs19@iiitranchi.ac.in>
Signed-off-by: Yash Pandey (YP) <yash.btech.cs19@iiitranchi.ac.in>
This issue has been resolved and is ready to be merged |
|
🎉 This PR is included in version 1.31.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yash Pandey (YP) yash.btech.cs19@iiitranchi.ac.in
Description
This code:
const std::string¶meters tostd::string_viewto allow direct manipulations of strings.std::vector<T>::push_back()without reallocations.static_cast/dynamic_castto facilitate long-term debugging.casbin::JoinSlice(),casbin::ArrayEquals()and other utlity functions.Important Note
The revised implementation of
casbin::ArrayEquals()is showing ambiguous behavior. This caused many tests to fail, which I commented out in this PR. This shall not propagate tocasbin::master, so I am reverting back those changes.