Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] The editor in official documentation should support keyMatch5 #73

Closed
klren0312 opened this issue Apr 13, 2022 · 7 comments · Fixed by #74
Closed

[Feature] The editor in official documentation should support keyMatch5 #73

klren0312 opened this issue Apr 13, 2022 · 7 comments · Fixed by #74
Assignees
@hsluoyz
Labels
enhancement New feature or request

Comments

@klren0312
Copy link

Is your feature request related to a problem? Please describe.
The code has keyMatch5 but the editor doesn't support it

Describe the solution you'd like
Add the keyMatch5 support

Additional context
example: https://casbin.org/casbin-editor/#8BUESA7BC
1649859088(1)
@klren0312 klren0312 added the enhancement New feature or request label Apr 13, 2022
@casbin-bot
Copy link
Member

@tangyang9464 @closetool @sagilio

@hsluoyz hsluoyz transferred this issue from casbin/casbin Apr 13, 2022
@casbin-bot
Copy link
Member

@Gabriel-403 @Zxilly @kingiw @nodece

@hsluoyz
Copy link
Member

hsluoyz commented Apr 13, 2022

@nodece @Zxilly

@Zxilly
Copy link
Contributor

Zxilly commented Apr 13, 2022

we should first add it to node-casbin

@hsluoyz hsluoyz mentioned this issue Apr 13, 2022
Closed
@hsluoyz
Copy link
Member

hsluoyz commented Apr 15, 2022

@klren0312 casbin/node-casbin#357 has been resolved, can you also make a PR to add keyMatch5 to this editor?

@Zxilly Zxilly mentioned this issue Apr 15, 2022
Merged
@Zxilly
Copy link
Contributor

Zxilly commented Apr 15, 2022 •
edited

@hsluoyz casbin-editor use beta branch of node-casbin, I have submit a sync PR to beta branch.

@klren0312
Copy link
Author

klren0312 commented Apr 15, 2022 •
edited

need to upgrade casbin.js 's node-casbin version

@Zxilly Zxilly mentioned this issue Apr 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsluoyz hsluoyz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: upgrade casbin
4 participants
@hsluoyz @klren0312 @Zxilly @casbin-bot