Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delete grouping policies with index 0 as well in DeleteRole() API #1364

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

Marif226
Copy link
Contributor

@Marif226 Marif226 commented Feb 22, 2024

Fix: #1363

Delete grouping policies with index 0, when deleting a role, so that role is deleted completely

@casbin-bot
Copy link
Member

@tangyang9464 @JalinWang please review

@hsluoyz hsluoyz changed the title refactor: add complete role deleting for enforcer's DeleteRole method feat: delete grouping policies with index 0 as well in DeleteRole() API Mar 31, 2024
@hsluoyz hsluoyz merged commit ef82104 into casbin:master Mar 31, 2024
12 checks passed
Copy link

🎉 This PR is included in version 2.86.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] Why doesn't DeleteRole delete role completely from the policies?
3 participants