Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update gorm and gorm-drivers #184

Merged
merged 2 commits into from Oct 18, 2022
Merged

Conversation

dsuket
Copy link
Contributor

@dsuket dsuket commented Oct 13, 2022

update gorm and gorm-drivers to latest.

@casbin-bot
Copy link
Member

@tangyang9464 @JalinWang @imp2002 please review

@CLAassistant
Copy link

CLAassistant commented Oct 13, 2022

CLA assistant check
All committers have signed the CLA.

@hsluoyz
Copy link
Member

hsluoyz commented Oct 13, 2022

@dsuket fix:

image

@dsuket
Copy link
Contributor Author

dsuket commented Oct 14, 2022

@hsluoyz Thank you for your information. I agreed license.

@dsuket
Copy link
Contributor Author

dsuket commented Oct 14, 2022

But, build faled.

Error: ../../../go/pkg/mod/gorm.io/gorm@v1.24.0/logger/logger.go:72:24: undefined: io.Discard

It seemd Go version is lower. io.Discard used by gorm/logger is avaliable from Go 1.16.
May I update go-version of ci to 1.16?

@hsluoyz
Copy link
Member

hsluoyz commented Oct 14, 2022

@dsuket OK

@dsuket
Copy link
Contributor Author

dsuket commented Oct 14, 2022

I fixed go version for ci.
Please, check it again.

@hsluoyz
Copy link
Member

hsluoyz commented Oct 14, 2022

@dsuket sign CLA

@dsuket
Copy link
Contributor Author

dsuket commented Oct 18, 2022

Sorry, I signed CLA again.

@hsluoyz hsluoyz changed the title update gorm and gorm-drivers feat: update gorm and gorm-drivers Oct 18, 2022
@hsluoyz hsluoyz merged commit 198ef24 into casbin:master Oct 18, 2022
@github-actions
Copy link

🎉 This PR is included in version 3.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@dsuket dsuket deleted the update-gorm-version branch October 19, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants