Added support for gorm/v2 #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: l1ghtman2k <aibek.zhil@gmail.com>
|
Please review the versioning change I made in the go.mod file, as I am not sure how exactly the versioning supposes to happen in this case. (In this pull request, I made it github.com/casbin/gorm-adapter/v3) |
nodece
reviewed
Jul 22, 2020
| @@ -9,7 +9,7 @@ Gorm Adapter | |||
| [](https://gitter.im/casbin/lobby) | |||
| [](https://sourcegraph.com/github.com/casbin/gorm-adapter?badge) | |||
|
|
|||
| Gorm Adapter is the [Gorm](https://github.com/jinzhu/gorm) adapter for [Casbin](https://github.com/casbin/casbin). With this library, Casbin can load policy from Gorm supported database or save policy to it. | |||
| Gorm Adapter is the [Gorm](https://gorm.io/gorm) adapter for [Casbin](https://github.com/casbin/casbin). With this library, Casbin can load policy from Gorm supported database or save policy to it. | |||
There was a problem hiding this comment.
You should update import path for gorm-adapter.
There was a problem hiding this comment.
Fixed with c780b42
nodece
reviewed
Jul 22, 2020
adapter.go
Outdated
| @@ -94,9 +88,6 @@ func NewAdapter(driverName string, dataSourceName string, dbSpecified ...bool) ( | |||
| return nil, err | |||
| } | |||
|
|
|||
| // Call the destructor when the object is released. | |||
| runtime.SetFinalizer(a, finalizer) | |||
There was a problem hiding this comment.
I think I did it at the time due to gorm changing the default closure statement for the database(I assumed gorm/v2 did not need a Close() call). I believe I misinterpreted it, and after reading go-gorm/gorm#3145, I have returned a modified finalizer(9e04eef).
Signed-off-by: l1ghtman2k <aibek.zhil@gmail.com>
Signed-off-by: l1ghtman2k <aibek.zhil@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gorm v2 has been released on gorm.io/gorm
Documentation is currently under http://v2.gorm.io/
This pull request aims to make gorm-adapter work with gorm/v2