fix: fix validation logic and added Reame #4
Conversation
Signed-off-by: ashish493 <b218008@iiit-bh.ac.in>
Signed-off-by: ashish493 <b218008@iiit-bh.ac.in>
Signed-off-by: ashish493 <b218008@iiit-bh.ac.in>
Signed-off-by: ashish493 <b218008@iiit-bh.ac.in>
Signed-off-by: ashish493 <b218008@iiit-bh.ac.in>
Signed-off-by: ashish493 <b218008@iiit-bh.ac.in>
|
@hsluoyz
Writing tests for k8s validation controller was much harder than expected, I will try to add it by this week. I will also try to add the build.sh and Makefile with the tests. Rest everything is working fine. |
|
I have forked the casbin-website repo. I just had a doubt that under which section should I write the docs for integrating k8s? Advanced usage? |
Yes, Advanced usage is OK. |
| @@ -15,11 +15,11 @@ spec: | |||
| spec: | |||
| containers: | |||
| - name: webhook | |||
| image: casbin/docker:1.0.0 | |||
| image: k8s_authz:latest | |||
There was a problem hiding this comment.
Using latest seems to be a hidden danger.
|
|
||
| e, err := casbin.NewEnforcer("./example/model.conf", "./example/policy.csv") | ||
| if err != nil { | ||
| glog.Errorf("Filed to load the policies: %v", err) |
|
@nodece, I have made the necessary changes and have changed the docs according to it. |
|
@ashish493 can you turn the logo into transparent background?
|
Sure, I will do that. |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Signed-off by: ashish493 b218008@iiit.bh.ac.in