Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decode CasbinRule #49

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Conversation

houxul
Copy link
Contributor

@houxul houxul commented Aug 12, 2022

CasbinRule uses the last value when a field does not exist in the mongodb document

@CLAassistant
Copy link

CLAassistant commented Aug 12, 2022

CLA assistant check
All committers have signed the CLA.

@casbin-bot
Copy link
Member

@tangyang9464 @JalinWang @imp2002 please review

@hsluoyz
Copy link
Member

hsluoyz commented Aug 12, 2022

@houxul plz fix:

image

@coveralls
Copy link

coveralls commented Aug 12, 2022

Coverage Status

Coverage decreased (-0.04%) to 83.333% when pulling d712242 on houxul:fix/decode-casbin-rule into a1f441b on casbin:master.

When a field does not exist in the mongodb document, CasbinRule uses the last value, expecting the field to be empty
@houxul
Copy link
Contributor Author

houxul commented Aug 12, 2022

plz

done

@hsluoyz hsluoyz merged commit 293a343 into casbin:master Aug 12, 2022
@github-actions
Copy link

🎉 This PR is included in version 3.3.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants