New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] priority_policy_explicit does not respect priority #248
Labels
enhancement
New feature or request
Comments
hsluoyz
added this to Node-Casbin Easy Tasks
in Casbin Easy Tasks for Beginners/Student Applicants
Mar 17, 2021
working on this |
Currently pycasbin didn't supoort explicit priority enforce. I'll implement it. |
hsluoyz
added
enhancement
New feature or request
and removed
bug
Something isn't working
labels
Mar 17, 2021
hsluoyz
pushed a commit
that referenced
this issue
Mar 23, 2021
* test: add unit tests for explicit priority model Signed-off-by: Zxilly <zhouxinyu1001@gmail.com> * feat: add priority_policy_explicit support #248 Signed-off-by: Zxilly <zhouxinyu1001@gmail.com> * perf: enhance batch action performance Signed-off-by: Zxilly <zhouxinyu1001@gmail.com> * style: small fix Signed-off-by: Zxilly <zhouxinyu1001@gmail.com> * fix: change function argument Signed-off-by: Zxilly <zhouxinyu1001@gmail.com> * fix: fix incorrect implement Signed-off-by: Zxilly <zhouxinyu1001@gmail.com> * refactor: refactor priority index Signed-off-by: Zxilly <zhouxinyu1001@gmail.com> * feat: add update priority unittest Signed-off-by: Zxilly <zhouxinyu1001@gmail.com> * perf: priority performance enhanced Signed-off-by: Zxilly <zhouxinyu1001@gmail.com> * refactor: refactor updatePolicy() throw error when new rule and old rule didn't have same priority Signed-off-by: Zxilly <zhouxinyu1001@gmail.com>
hsluoyz
removed this from Node-Casbin Easy Tasks
in Casbin Easy Tasks for Beginners/Student Applicants
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
priority_policy_explicit is still positional, not respecting priority.
To Reproduce
Steps to reproduce the behavior:
examples/priority_model_explicit.conf
andexamples/priority_policy_explicit.csv
priority_policy_explicit.csv
:Expected behavior
The priority based policy should work regardless of the order of adding policies and be consistent to
true
("allow"), due to bob is in data2_allow_group which has a higher priority.Screenshots
Desktop (please complete the following information):
Additional context
None
The text was updated successfully, but these errors were encountered: