perf: refacto & slight performance improvements #126
Conversation
yo-main
changed the title
|
I'm OK with useful refactoring. But I don't like some changes that make the code obscure. Code readability and maintainability are the first thing we consider. |
|
Hi @hsluoyz, would you mind to let me know which part exactly aren't clear enough ? I don't mind to rework them or set it back as it originally was. But I think some part would really bring a performance boost. We are currently setting up Casbin to manage hundreds of thousands of rules (groups & permissions) and we started to have performance issues when provisioning roles. Changes like this one or this one would definitively avoid some computation which aren't needed and this would be noticeable for operation done in huge batch. |
|
@yo-main ok, don't remove the param names like |
yo-main
force-pushed
the
master
branch
4 times, most recently
from
d5805ce
to
070a781
Compare
|
Done, I do agree with you that it makes it less readable. I've reverted my changes. Thank you for the feedback ! |
Signed-off-by: Romain Arnal <romain.arnal@sewan.fr>
|
🎉 This PR is included in version 0.18.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Hi !
I closed my previous pull request for this (#125) because I messed up my files and I redid everything from scratch (my apologies for this)....
This PR is about a bunch of small modifications that takes advantages of some python idioms and should slightly improve performances.
I tried not to break any logic, and all tests are working, but I might have missed a few things here or there.
Many thanks !