Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump github.com/redis/go-redis/v9 #43

Merged
merged 21 commits into from
Apr 2, 2023

Conversation

sixcolors
Copy link
Contributor

@sixcolors sixcolors commented Mar 24, 2023

Fix: #42

updated form github.com/go-redis/redis/v8 to github.com/redis/go-redis/v9

@casbin-bot
Copy link
Member

@tangyang9464 @JalinWang @imp2002 please review

@CLAassistant
Copy link

CLAassistant commented Mar 24, 2023

CLA assistant check
All committers have signed the CLA.

@hsluoyz
Copy link
Member

hsluoyz commented Mar 25, 2023

@sixcolors update README:

image

@hsluoyz
Copy link
Member

hsluoyz commented Mar 25, 2023

@sixcolors also fix CI:

image

@sixcolors
Copy link
Contributor Author

@sixcolors also fix CI:

image

Checking this now.

@hsluoyz
Copy link
Member

hsluoyz commented Mar 25, 2023

@sixcolors For the CI error undefined: reflect.Pointer, see: https://github.com/redis/go-redis/search?q=undefined%3A+reflect.Pointer&type=issues and their merged fix: redis/go-redis#2458 . Given that this PR is not released in latest version v9.0.2, I think we can use the master head commit in our go.mod, not the version, to make this repo support Go 1.17.

And you should provide a notice like "For Go 1.17+, use v2.4.0+. For Go 1.16 and below, stay on v2.3.0" in the beginning of README, not so short like my example but the similar meaning. The notice is a form like: https://github.com/casbin/gorm-adapter

Also change the v8 text in README

@sixcolors
Copy link
Contributor Author

sixcolors commented Mar 25, 2023

@sixcolors For the CI error undefined: reflect.Pointer, see: https://github.com/redis/go-redis/search?q=undefined%3A+reflect.Pointer&type=issues and their merged fix: redis/go-redis#2458 . Given that this PR is not released in latest version v9.0.2, I think we can use the master head commit in our go.mod, not the version, to make this repo support Go 1.17.

And you should provide a notice like "For Go 1.17+, use v2.4.0+. For Go 1.16 and below, stay on v2.3.0" in the beginning of README, not so short like my example but the similar meaning. The notice is a form like: https://github.com/casbin/gorm-adapter

Also change the v8 text in README

The go.mod was at 1.18 so I bumped CI to that.

The README.md is updated, with /v9

I bumped all of the other CI action versions and also semantic-release

@sixcolors
Copy link
Contributor Author

@hsluoyz seeing as how that go is 1.20.x and the go.mod is go 1.18 do we just want to make the minimum supported version 1.18 for watcher?

@hsluoyz
Copy link
Member

hsluoyz commented Mar 25, 2023

@sixcolors no, finally go-redis new version will be released with Go 1.17 support, there's no reason that we give it up

@sixcolors
Copy link
Contributor Author

@sixcolors no, finally go-redis new version will be released with Go 1.17 support, there's no reason that we give it up

I'll ping the devs on discord and see if they can do a release, I would prefer that over the HEAD commit.

sixcolors and others added 9 commits March 25, 2023 13:23
* build: bump github.com/redis/go-redis/v9.

* fix: bump github.com/redis/go-redis/v9.

* fix: fix CI.

* fix: fix CI.

* fix: change node.js version from 16 to 18

* fix: change node.js version from 16 to 18
@sixcolors
Copy link
Contributor Author

sixcolors commented Mar 26, 2023

PR hijacked by #45

@sixcolors
Copy link
Contributor Author

@hsluoyz go-redis 9.0.3 released. PR updated and ready for merge.

@hsluoyz hsluoyz changed the title build: bump github.com/redis/go-redis/v9 feat: bump github.com/redis/go-redis/v9 Apr 2, 2023
@hsluoyz hsluoyz merged commit fed3072 into casbin:master Apr 2, 2023
@github-actions
Copy link

github-actions bot commented Apr 2, 2023

🎉 This PR is included in version 2.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

ShuaiGao added a commit to ShuaiGao/redis-watcher that referenced this pull request Jun 27, 2023
feat: bump github.com/redis/go-redis/v9 (casbin#43)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update to github.com/redis/go-redis/v9
5 participants