-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump github.com/redis/go-redis/v9 #43
Conversation
@tangyang9464 @JalinWang @imp2002 please review |
@sixcolors update README: |
@sixcolors also fix CI: |
Checking this now. |
@sixcolors For the CI error And you should provide a notice like "For Go 1.17+, use v2.4.0+. For Go 1.16 and below, stay on v2.3.0" in the beginning of README, not so short like my example but the similar meaning. The notice is a form like: https://github.com/casbin/gorm-adapter Also change the |
The go.mod was at 1.18 so I bumped CI to that. The README.md is updated, with /v9 I bumped all of the other CI action versions and also semantic-release |
@hsluoyz seeing as how that go is 1.20.x and the go.mod is go 1.18 do we just want to make the minimum supported version 1.18 for watcher? |
@sixcolors no, finally go-redis new version will be released with Go 1.17 support, there's no reason that we give it up |
I'll ping the devs on discord and see if they can do a release, I would prefer that over the HEAD commit. |
* build: bump github.com/redis/go-redis/v9. * fix: bump github.com/redis/go-redis/v9. * fix: fix CI. * fix: fix CI. * fix: change node.js version from 16 to 18 * fix: change node.js version from 16 to 18
PR hijacked by #45 |
@hsluoyz go-redis 9.0.3 released. PR updated and ready for merge. |
🎉 This PR is included in version 2.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
feat: bump github.com/redis/go-redis/v9 (casbin#43)
Fix: #42
updated form github.com/go-redis/redis/v8 to github.com/redis/go-redis/v9