Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix bug in Postgres dialect where if a table already exists then it would give error (Invalid query) #58

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

vishal-bihani
Copy link
Contributor

Current version of Xorm in this adapter has a bug in Postgres dialect where if a table already exists then it would give error (Invalid query)

Screenshot 2023-08-16 at 5 05 10 PM

For your reference: https://gitea.com/xorm/xorm/pulls/1779

Updating the Xorm dependency resolved the issue.

@casbin-bot
Copy link
Member

@tangyang9464 @JalinWang @imp2002 please review

@CLAassistant
Copy link

CLAassistant commented Aug 16, 2023

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

coverage: 70.737%. remained the same when pulling cd3fd77 on vishal-bihani:master into 2bfc453 on casbin:master.

@hsluoyz hsluoyz changed the title Fix: Invalid PG query feat: fix bug in Postgres dialect where if a table already exists then it would give error (Invalid query) Aug 16, 2023
@hsluoyz hsluoyz merged commit 047522b into casbin:master Aug 16, 2023
3 of 4 checks passed
@github-actions
Copy link

🎉 This PR is included in version 3.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants