-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add helm for k8s and makefile #444
Conversation
@seriouszyx @tangyang9464 please review |
a99710f
to
b3d3194
Compare
fa98ca0
to
f8d1504
Compare
@henrywangx plz fix: |
@hsluoyz, I have signed with my account. Suppose it's ok now |
@ComradeProgrammer @Steve0x2a @seriouszyx plz review |
538f7b0
to
0a3e70e
Compare
Well I think I have some questions:
|
@henrywangx can you join the QQ group: 645200447 for discussion? |
|
Signed-off-by: henrywangx <henrywangx@gmail.com>
@henrywangx I'm OK to have better integration with k8s and helm, but this PR seems to add too many things that don't natively belong to Casdoor. Can we put this PR into some places like a casdoor-k8s-plugin? In the plugin repo, we can refer to Casdoor repo (this repo) via git submodules or other methods. What do you think? |
@hsluoyz
All those things should be necessary, since I found it's too difficult to deploy casdoor into production env. If community think it's too heavy, just close this PR. |
🎉 This PR is included in version 1.17.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
@henrywangx thanks for your contribution! Can you also add docs to: https://casdoor.org/docs/deploy/k8s ? |
Signed-off-by: henrywangx <henrywangx@gmail.com> Co-authored-by: xiong wang <xiong.wang@inceptio.ai>
No description provided.