Amy Kintner's job-tracker #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tory girl blowing up
case-eee
reviewed
Jan 2, 2017
| has_many :contacts | ||
|
|
||
|
|
||
| def self.top_3_by_average_interest |
There was a problem hiding this comment.
i don't see tests for these model methods
| belongs_to :category | ||
| has_many :comments | ||
|
|
||
| def self.count_by_interest |
There was a problem hiding this comment.
same here - don't forget to tests these methods!
|
|
||
| def create | ||
| @contact = Contact.new(contact_params) | ||
| @contact.company_id = params[:company_id] |
There was a problem hiding this comment.
leverage your associations here rather than setting the foreign key manually
| <div class="form-group"> | ||
|
|
||
| <% if @category.errors.any? %> | ||
| <h2><%= pluralize(@category.errors.count, "error") %> prohibited this record from being saved:</h2> |
| <br/> | ||
| <%= f.label :email %> | ||
| <%= f.text_field :email %> | ||
| <%= hidden_field_tag :company_id, @company.id %> |
There was a problem hiding this comment.
how can we avoid passing hidden fields in our forms?
|
|
||
| <br/> | ||
| <%= f.label :job_category %> | ||
| <%= f.collection_select :category_id, Category.order(:title), :id, :title, include_blank: false %> |
There was a problem hiding this comment.
avoid querying your database in your views (Category.order(:title))
| <h3>Jobs in Each Location</h3> | ||
| <% if self.count_by_location %> | ||
| <ul class="by_location list-unstyled"> | ||
| <li><%= <% Job.order(:city) %></li> |
There was a problem hiding this comment.
remove this from the view - let your controller get this data 👍
| <ul class="nav navbar-nav"> | ||
| <li class="nav navbar-nav"><a href="/dashboard">Job Dashboard</a></li> | ||
| <li class="nav navbar-nav"><a href="/companies">Companies</a></li> | ||
| <li class="nav navbar-nav"><a href="/categories">Job Categories </a></li> |
There was a problem hiding this comment.
leverage your rail's helpers - link_to and your path helpers
| @@ -0,0 +1,45 @@ | |||
| FactoryGirl.define do | |||
| require 'rails_helper' | ||
|
|
||
| describe "User creates a new category" do | ||
| scenario "a user can create a new category" do |
|
hey @akintner - overall, good work with this. i made a few comments. be sure to remember to commit more often as well 👍 Rubric1) Database, Relationships, and Migrations
2) Routes
3) Controllers
4) ActiveRecord
5) Views
6) User Experience
7) Testing
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.