Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sublime Text syntax file #864

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Add Sublime Text syntax file #864

merged 1 commit into from
Jun 10, 2021

Conversation

casey
Copy link
Owner

@casey casey commented Jun 10, 2021

No description provided.

@casey casey mentioned this pull request Jun 10, 2021
@casey casey merged commit 58fd747 into master Jun 10, 2021
@casey casey deleted the sublime-syntax branch June 10, 2021 02:20
@Frederick888
Copy link
Contributor

I'm thinking about adding file_extensions: [Justfile], but I don't use Sublime so not sure if it's ok.

Although http://www.sublimetext.com/docs/syntax.html is unclear about files without extensions, it seems the same rule for files without basenames, i.e. using full name, also applies in practice. For example, https://github.com/sublimehq/Packages/blob/master/Makefile/Makefile.sublime-syntax.

I'm asking this cos I'd like to use this file in bat and it ignores syntaxes without this attribute: https://github.com/sharkdp/bat/blob/12ecb325c911d2f059962ca71f5d90b87f92dc85/src/bin/bat/main.rs#L87

@casey
Copy link
Owner Author

casey commented Jun 24, 2021

Interesting! I don't have any experience with Sublime. It should probably be [Justfile, just], since .just is also a possibility.

I'm guessing that anything that doesn't understand this attribute will just ignore it, so I'd be happy to merge a PR adding the attribute.

Frederick888 added a commit to Frederick888/just that referenced this pull request Jun 24, 2021
Although [1] is unclear about files without extensions, it seems the
same rule for files without basenames, i.e. using full name, also
applies in practice. For example, [2].

This also allows bat [3] to import this file [4].

In addition to `Justfile`, `just` is also added as suggested [5].

[1] http://www.sublimetext.com/docs/syntax.html
[2] https://github.com/sublimehq/Packages/blob/master/Makefile/Makefile.sublime-syntax
[3] https://github.com/sharkdp/bat
[4] https://github.com/sharkdp/bat/blob/12ecb325c911d2f059962ca71f5d90b87f92dc85/src/bin/bat/main.rs#L87
[5] casey#864 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants