Replace dependency on fishhook with inlined code #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Sherlouk |
|
Awesome stuff! |
efirestone
approved these changes
Nov 3, 2020
NickEntin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fishhook is currently blocking SPM support (#1) and hasn't been merging PRs recently, so it looks like that support likely isn't coming soon. This removes our dependency on Fishhook by inlining the code that we use from it. If Fishhook ends up getting more updates in the future, we can consider re-adding it as a dependency.
Probably easiest to review by commit. The first commit copies in the code from Fishhook and the remaining commits extract out parts of it that we don't need.