autoversion: Support CSS selectors #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autoversion currently only supports XPath for searching for versions
in an HTML page.
This works great, but CSS selectors are arguably
more approachable for newcomers, and more widely understood.
This change adds support for CSS selectors to autoversion
using the github.com/andybalholm/cascadia package (BSD2 licensed)
for matching them.
To fit that in, this extracts the search logic into a new abstraction
called htmlMatcher with an implementation for XPath and one for CSS.
Following this change, you can do something like the following:
```hcl
auto-version {
html {
url = "https://example.com"
css = "div.version"
}
}
```
It is invalid to specify both `xpath` and `css`
in the same auto-version block.
|
That's awesome! I originally chose XPath because it's much more powerful, allowing selection of regex subgroups, among other things. But I think you're right, CSS is much more approachable and should be fine for most use cases. |
alecthomas
requested changes
Feb 6, 2024
If no versions are found, we should return an error instead of panicking. We just need to add a check for the length of the versions slice before returning the latest version.
alecthomas
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autoversion currently only supports XPath for searching for versions
in an HTML page.
This works great, but CSS selectors are arguably
more approachable for newcomers, and more widely understood.
This change adds support for CSS selectors to autoversion
using the github.com/andybalholm/cascadia package (BSD2 licensed)
for matching them.
To fit that in, this extracts the search logic into a new abstraction
called htmlMatcher with an implementation for XPath and one for CSS.
Following this change, you can do something like the following:
It is invalid to specify both
xpathandcssin the same auto-version block.