Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Pin fails when bumping to a newer version with a package that wasn't published on old version #448

Open
adrw opened this issue Aug 15, 2019 · 0 comments

Comments

@adrw
Copy link
Collaborator

adrw commented Aug 15, 2019

Make pin resilient enough to not leave the tab in an unrecoverable state where

  • the miskTab version hasn't been bumped
  • AND package.json has been regenerated now to reference a new package with an old version (that was never published and doesn't exist)

Example

  • @misk/prettier wasn't released until 0.1.15-ish
  • Pin a tab from version 0.1.7 to latest (0.1.17)
  • Pin fails and version remains at 0.1.7
  • package.json gets regenerated but now to reference @misk/prettier @ 0.1.7 that doesn't exist
  • Failure has to be manually resolved by setting the version in miskTab.json, running prebuild and then ci-build

Debug

[MIGRATE][ORDERS]
[GENERATE][ORDERS]
[WARN][ORDERS] Cannot resolve @misk/prettier@0.1.5 on NPM.
[GENERATE][ORDERS] Up to date build files generated using Misk Web @ 0.1.5

> misk-web-tab-orders@0.1.5 prebuild /Users/adrw/Development/cash-services/invest-broker-admin/service/web/tabs/orders
> npm run-script lint


> misk-web-tab-orders@0.1.5 lint /Users/adrw/Development/cash-services/invest-broker-admin/service/web/tabs/orders
> prettier --write --config package.json ".{/src/**/,/}*.{md,css,scss,less,json,js,jsx,ts,tsx}"

[error] Invalid configuration file: Cannot find module '@misk/prettier' from '/Users/adrw/Development/cash-services/invest-broker-admin/service/web/tabs/orders'
@adrw adrw added the @misk/cli label Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant