[CLOSES #179] Plugin Publish and Revert to Groovy #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The bullet points you listed out would have been great granular commits. Can we try to do that in the future? |
wesleyk
approved these changes
Feb 23, 2019
| } | ||
|
|
||
| test { | ||
| testm2 { |
There was a problem hiding this comment.
To make it more clear that this is integration testing of the public published on M2 plugin vs the locally built version tested with testlocal.
There was a problem hiding this comment.
hmm okay, can you leave a comment on each task?
misk-web/settings.gradle
Outdated
| @@ -0,0 +1,21 @@ | |||
| //pluginManagement { | |||
There was a problem hiding this comment.
what's up with all this commented out stuff? Remove it or leave a note why it's commented out?
There was a problem hiding this comment.
Oops I thought I had gotten all of it, I'll remove it and force push.
* [RELEASE] `misk-web-plugin:201902211512-8d6fdea` * Publish to Gradle M2 repository * Using https://plugins.gradle.org/docs/publish-plugin#kotlin-example * Revert `misk-web` directory to Groovy from Kotlin DSL so internal `hooks.gradle` work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
misk-web-plugin:201902211512-8d6fdeamisk-webdirectory to Groovy from Kotlin DSL so internalhooks.gradlework