Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable kochiku in CI #2351

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Conversation

ctaslimsq
Copy link
Collaborator

@ctaslimsq ctaslimsq commented Apr 4, 2022

allowing test codes to be able to point to the appropriate service/datastore in a docker bridge environment. Since all docker started services is mapped back to the host machine, the CI code should repoint "localhost" to "host.docker.internal" which is where the docker service port is being exposed to. https://docs.docker.com/desktop/mac/networking/#use-cases-and-workarounds

I believe the non-test code files are ok to be changed due to the reasoning of: generally the data backing store in production should almost never be localhost

There is 1 more change to the jks store where i regenerated the keystore to contain a cert which has a SAN entry of "host.docker.internal" instead of "only localhost"

old :

Certificate:
    Data:
        Version: 3 (0x2)
        Serial Number: 18589796 (0x11ba864)
    Signature Algorithm: sha256WithRSAEncryption
        Issuer: C=US, ST=CA, L=San Francisco, O=Misk, OU=Client, CN=misk-client
        Validity
            Not Before: Feb 23 11:41:48 2018 GMT
            Not After : Jan 28 11:41:48 2023 GMT
        Subject: C=US, ST=CA, L=San Francisco, O=Misk, OU=Client, CN=misk-client
        Subject Public Key Info:
            Public Key Algorithm: rsaEncryption
                Public-Key: (2048 bit)
                Modulus:
                    00:d9:ca:74:21:8a:12:3d:d5:6f:f4:e3:48:23:0f:
                    92:d1:7f:55:a9:be:f3:12:88:75:4e:28:fd:2e:96:
                    99:15:6e:1b:d5:15:bf:b6:6e:bd:33:2f:77:94:f4:
                    24:3b:10:5b:5c:e6:ff:43:94:a4:80:ae:47:33:b8:
                    60:39:18:3f:5d:bf:cb:3c:18:38:50:e1:b1:03:d5:
                    b4:16:32:ae:2b:52:13:a7:45:6d:23:7d:c7:ca:ac:
                    27:10:a6:cc:92:cc:ad:0e:92:05:cc:7f:01:a8:d7:
                    58:4e:62:7b:c5:ce:5c:54:16:50:8a:61:df:6a:8f:
                    48:6a:9d:92:f4:f1:15:4a:7b:a9:9a:34:ed:55:f2:
                    d4:46:7a:ec:82:d5:4e:68:69:53:ec:ae:3f:3c:81:
                    98:f9:e1:2e:c0:a5:ee:b9:10:69:0d:71:25:aa:f9:
                    bb:bd:e4:d7:83:79:5c:b8:29:f2:6d:ab:52:66:24:
                    4a:53:36:6a:17:42:d8:6a:57:da:b5:b8:76:39:68:
                    93:82:c1:a8:0f:5a:5d:f5:0d:60:b3:0c:38:d9:de:
                    cc:dc:8f:e7:06:21:92:a0:71:05:ed:8e:aa:60:ca:
                    c2:f1:01:e9:5e:34:38:a8:c0:fd:96:75:8a:9b:18:
                    10:c1:cd:f1:0c:6a:6c:a8:48:32:7c:60:fb:99:74:
                    12:45
                Exponent: 65537 (0x10001)
        X509v3 extensions:
            X509v3 Subject Key Identifier: 
                F9:6A:21:2C:50:7B:19:88:0F:A3:70:5E:DE:B7:97:31:5D:A8:72:BB
            X509v3 Subject Alternative Name: 
                IP Address:127.0.0.1
    Signature Algorithm: sha256WithRSAEncryption
         c3:b9:bb:f4:23:5f:ed:0e:ae:02:b3:28:9e:99:0c:bd:4e:df:
         b7:f6:dd:9b:ba:82:3d:7b:03:3e:23:81:c4:6f:09:44:75:9d:
         ec:64:0a:28:53:0f:99:3f:96:52:ed:cd:47:3e:a8:df:5c:b4:
         27:89:a6:24:7e:88:9f:73:e7:f7:9b:f6:02:48:4c:6d:db:86:
         ab:ea:61:7b:8c:41:00:91:b4:ed:d9:bb:60:da:86:52:af:ff:
         b5:f7:15:4b:29:f7:c0:bd:67:fd:96:f1:6e:e4:61:32:1d:b6:
         12:08:55:84:ff:79:ad:62:7c:e5:59:b5:3e:5e:23:87:b4:1b:
         b2:b5:7a:fe:eb:79:a2:a2:1b:06:3f:63:14:19:f3:1e:9d:60:
         fd:3c:f3:33:70:50:b9:6f:16:ea:8c:c4:79:b7:24:c8:7e:00:
         dc:9f:e6:c9:76:c5:7d:ea:5a:aa:c3:a5:ff:2b:da:25:81:1b:
         35:63:e8:57:7c:3c:77:fa:4c:be:a7:70:6e:67:13:42:0f:c3:
         94:40:7f:e1:88:4a:9c:ff:4a:b5:1d:6d:4c:46:36:b5:57:de:
         b3:d5:92:c5:5f:2f:35:8d:18:7f:3f:6b:bb:e6:d6:8d:41:e2:
         18:64:ac:84:04:bc:bd:b8:57:c9:99:65:6b:90:a9:a6:31:00:
         47:4c:bf:e0

new:

Certificate:
    Data:
        Version: 3 (0x2)
        Serial Number: 2012198718 (0x77efb73e)
    Signature Algorithm: sha256WithRSAEncryption
        Issuer: C=US, ST=CA, L=San Francisco, O=Misk, OU=Client, CN=misk-client
        Validity
            Not Before: Feb 28 20:13:52 2022 GMT
            Not After : Feb  2 20:13:52 2027 GMT
        Subject: C=US, ST=CA, L=San Francisco, O=Misk, OU=Client, CN=misk-client
        Subject Public Key Info:
            Public Key Algorithm: rsaEncryption
                Public-Key: (2048 bit)
                Modulus:
                    00:88:c5:54:bf:5b:87:9c:65:88:5e:52:7b:90:47:
                    cd:05:c2:88:4c:2c:c9:13:f2:91:51:42:a8:7c:5d:
                    2c:00:23:12:ca:24:41:3f:50:c7:cb:53:ab:d7:7e:
                    4a:61:e8:d6:a4:c3:b2:87:e7:51:d7:02:ee:71:3c:
                    3c:a0:8f:76:ec:6f:49:7f:fb:c6:b8:78:09:eb:ca:
                    63:06:9a:7d:74:ff:d8:ed:af:3b:cc:56:68:91:81:
                    45:ae:60:23:c1:19:a2:a7:07:e2:bc:12:42:76:e0:
                    19:7e:6b:fb:74:69:ff:b3:d5:3c:b4:80:b7:de:91:
                    80:b4:d2:8a:a9:88:f6:10:88:ec:f4:71:7b:9e:24:
                    f8:94:f8:fb:07:bc:49:0a:0f:12:5d:62:ce:24:31:
                    b0:8e:c2:f6:42:86:76:a7:db:c3:7b:2b:74:bb:2d:
                    83:de:45:68:9f:bd:d2:e6:80:fd:38:1b:5f:90:a4:
                    11:d0:db:7e:e2:20:94:80:89:93:72:4a:fc:3f:14:
                    1f:54:83:24:18:fd:e7:bf:1b:e2:10:52:e0:6a:32:
                    df:29:ec:4c:f8:97:6e:01:90:d2:86:95:38:da:f0:
                    32:a5:15:0e:c3:e2:e7:23:69:85:51:11:33:cc:d0:
                    bc:03:21:fc:6c:90:a3:62:16:96:67:53:50:fd:e1:
                    a8:25
                Exponent: 65537 (0x10001)
        X509v3 extensions:
            X509v3 Subject Key Identifier: 
                D3:8F:12:FC:59:03:11:85:2B:1D:E4:AE:82:8E:9F:E4:D8:10:BD:53
            X509v3 Subject Alternative Name: 
                DNS:host.docker.internal, IP Address:127.0.0.1
    Signature Algorithm: sha256WithRSAEncryption
         7c:b1:98:19:40:4f:01:2e:73:64:69:a0:29:1e:3e:7a:87:99:
         21:3c:99:0f:7d:02:da:15:2f:fc:5e:17:5f:36:cb:d1:13:00:
         0a:39:da:51:02:02:fb:3c:fe:ef:f4:6a:ba:b6:b0:71:61:86:
         0a:cf:e7:b4:14:c7:ca:f2:0c:ab:e2:41:ca:7c:62:5e:69:3e:
         f4:44:20:5a:83:5f:0f:67:36:09:63:14:ca:18:4e:72:10:a6:
         22:62:57:b5:97:33:3b:27:f5:7e:36:64:9c:fe:67:a1:1a:4a:
         d2:ec:40:62:bd:4f:83:83:7d:ac:58:a2:d7:bc:3e:94:7a:c5:
         87:e5:94:17:6d:b2:91:2b:6a:9e:44:d5:c4:de:ed:62:df:aa:
         6a:ff:4f:82:46:e8:b8:87:dc:45:08:90:ee:17:91:05:24:ce:
         fd:0f:73:a4:44:a0:07:c9:28:66:b0:ab:87:5d:f3:5d:bc:6f:
         78:1d:ad:84:42:dc:ed:25:f4:1b:24:05:c1:02:aa:f5:5a:e1:
         a7:db:55:bd:d1:9b:da:24:a2:e1:1a:92:a7:06:2c:82:4d:e0:
         78:18:3d:dd:aa:d0:fa:6f:88:8a:2a:a7:68:c0:86:6c:8b:81:
         d1:81:25:7b:07:91:16:29:1d:0b:1d:25:c6:4d:35:a8:ff:d9:
         18:e7:26:f7

@ctaslimsq ctaslimsq force-pushed the ctaslim/fix-all-unit-test-to-run-in-docker branch 18 times, most recently from a0ef8c8 to 397ec9d Compare April 13, 2022 15:01
@ctaslimsq ctaslimsq force-pushed the ctaslim/fix-all-unit-test-to-run-in-docker branch from 397ec9d to 6744d40 Compare April 13, 2022 16:10
@ctaslimsq ctaslimsq force-pushed the ctaslim/fix-all-unit-test-to-run-in-docker branch from 6744d40 to 43ae457 Compare April 13, 2022 17:31
@ctaslimsq ctaslimsq marked this pull request as ready for review April 14, 2022 01:09
@ctaslimsq ctaslimsq merged commit 6b24bf9 into master Apr 14, 2022
@ctaslimsq ctaslimsq deleted the ctaslim/fix-all-unit-test-to-run-in-docker branch April 14, 2022 01:09
mightyguava pushed a commit to cashapp/wisp that referenced this pull request Jul 12, 2022
rainecp pushed a commit that referenced this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants