Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allowing test codes to be able to point to the appropriate service/datastore in a docker bridge environment. Since all docker started services is mapped back to the host machine, the CI code should repoint "localhost" to "host.docker.internal" which is where the docker service port is being exposed to. https://docs.docker.com/desktop/mac/networking/#use-cases-and-workarounds
I believe the non-test code files are ok to be changed due to the reasoning of: generally the data backing store in production should almost never be localhost
There is 1 more change to the jks store where i regenerated the keystore to contain a cert which has a SAN entry of "host.docker.internal" instead of "only localhost"
old :
new: