Unified Jedis for Bucket4j #3102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgregory-block
requested review from
rainecp,
adrw,
frojasg and
ThePumpingLemma
| bucket4jMySQL = { module = "com.bucket4j:bucket4j-mysql", version = "8.5.0" } | ||
| bucket4jRedis = { module = "com.bucket4j:bucket4j-redis", version = "8.5.0" } | ||
| bucket4jCore = { module = "com.bucket4j:bucket4j-core", version = "8.7.0" } | ||
| bucket4jDynamoDbV1 = { module = "com.bucket4j:bucket4j-dynamodb-sdk-v1", version = "8.6.0" } |
There was a problem hiding this comment.
Are they not releasing an update for this library?
There was a problem hiding this comment.
No, the author actually dropped it from bucket4j because he is based in Russia and the various geoip based blocklists make working with it difficult from that locality
adrw
approved these changes
Jan 23, 2024
frojasg
reviewed
Jan 23, 2024
| @@ -2,10 +2,13 @@ package misk.redis | |||
|
|
|||
| import com.google.common.base.Stopwatch | |||
| import com.google.common.base.Ticker | |||
| import jakarta.inject.Inject | |||
There was a problem hiding this comment.
All the imports from the inject package seem to use jakarta, a search for import javax.inject returns nothing
frojasg
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Converts the misk bucket4j redis module to use
UnifiedJedis, consistent with the main redis module