Remove null from name on gif screenshots #917
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now when you run paparazzi with
gif
without setting a name the files that paparazzi create ends with_null_0.png
. That"null"
is thename
that was not set. This PR aligns the naming ofgif
andscreenshot
. Now, if you don't set a name ongif
the screenshot name will end with_0.png
.A diff is worth a thousand words:
BraisGabin@21bc089#diff-7522c35360e75c4ed0d453217b86bfe469ea3cc1b4cabc2597f1cbf9fc6d4173L55-R55
I splitted this PR in two commits. The first one extracts this logic to a different file and add tests to the current behaviour. On the second one I fix the naming issue.
Note: this PR shares the first commit with #902. I'll rebase this (or the other PR) when one of them is merged.