Run wall-clock timeout in GlobalScope #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I only ran JVM tests locally, so... hope they pass! |
JakeWharton
force-pushed
the
jw/timeout-on-global-scope/2022-11-03
branch
from
00d16be
to
4c22d44
Compare
jingibus
approved these changes
Nov 3, 2022
| // Run the timeout on a scope separate from the caller. This ensures that the use of the | ||
| // Default dispatcher does not affect the use of a TestScheduler and its fake time. | ||
| @OptIn(DelicateCoroutinesApi::class) | ||
| val timeoutJob = GlobalScope.launch(Dispatchers.Default) { delay(timeout) } |
There was a problem hiding this comment.
I am surprised that this works
shakes fist JAVASCRIIIIIIPT |
This uses the new memory manager by default.
This ensures its use of the Default dispatcher does not affect the use of a TestScheduler and its fake time.
JakeWharton
force-pushed
the
jw/timeout-on-global-scope/2022-11-03
branch
from
4c22d44
to
3ab00b8
Compare
|
Haha it's actually the Kotlin/Native tests which are breaking there and only the ones which run from a background thread. I ninja'd in a Kotlin 1.7.20 update commit which switches to the new memory model by default. This fixes the whole multithreaded coroutines saga once and for all (and makes the tests pass). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures its use of the Default dispatcher does not affect the use of a TestScheduler and its fake time.
Closes #164.