Mint API: Check ?amount is within a sensible range using FastAPI quer…
#227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AngusP
changed the title
?amount is within a sensible range using FastAPI quer…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variant of #226, but using FastAPI's own validation to do the check... catch is that this would require an update to the FastAPI version >= 0.95.0 (per the docs for
Query) -- related #178The Mint API /mint?amount= currently doesn't do any input validation to check that the amount is positive or a possible amount of sats (21 Quadrillion) leading to some errors downstream -- depending on the number, the DB will reject the insert query because the amount is over the maximum INTEGER or LNBits/Lightning Node will also reject it.