Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new cask for EPI2ME Agent v2.52.1202033 #44485

Closed
wants to merge 3 commits into from
Closed

Conversation

rmp
Copy link

@rmp rmp commented Mar 2, 2018

EPI2ME is a cloud analytics platform for data from genetic
sequencing devices made by Oxford Nanopore Technologies Ltd.
This cask is for the latest stable release of the EPI2ME desktop app.

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • brew cask install {{cask_file}} worked successfully.
    complains about permissions problems but unclear why when /Applications is writable
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked there are no open pull requests for the same cask.
  • Checked the cask was not already refused in closed issues.
  • Checked the cask is submitted to the correct repo.

Roger Pettett added 3 commits March 1, 2018 21:31
EPI2ME is a cloud analytics platform for data from genetic
sequencing devices made by Oxford Nanopore Technologies Ltd.
This cask is for the latest stable release of the EPI2ME desktop app.
@commitay
Copy link
Contributor

commitay commented Mar 2, 2018

This has been refused as a walled build.

Walled: When the download URL is both behind a login/registration form and from a host that differs from the homepage.

#44477 (comment)

@commitay commitay closed this Mar 2, 2018
@rmp
Copy link
Author

rmp commented Mar 2, 2018

Sure the URLs do differ but the download URL is open. I don't understand why this is classified as walled.

@commitay
Copy link
Contributor

commitay commented Mar 2, 2018

The only way to get the URL is behind a login/registration which means we can't verify it as offical.

@lock lock bot locked as resolved and limited conversation to collaborators May 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants