Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[application] Brainfuck Interpreter: Some additional changes/cleanups #51

Merged
merged 3 commits into from
Feb 25, 2018
Merged

[application] Brainfuck Interpreter: Some additional changes/cleanups #51

merged 3 commits into from
Feb 25, 2018

Conversation

emmanuel099
Copy link
Member

  • Inject step rule into Jump to make it easier to read (less let + less nesting)
  • Use abort instead of asset(false)
  • Fix the mem function FIXME

ppaulweber
ppaulweber approved these changes Feb 25, 2018
View reviewed changes
Copy link
Member

@ppaulweber ppaulweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks OK, well done, still with later release features we can improve this even further, but as I can see you already inserted proper TODO annotations

@ppaulweber ppaulweber merged commit 5f9ca9a into master Feb 25, 2018
@ppaulweber ppaulweber deleted the feature/application_brainfuck_interpreter_refactoring branch February 25, 2018 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppaulweber ppaulweber ppaulweber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@emmanuel099 @ppaulweber