Expand deploy acceptor checks #2085
Comments
This was referenced Sep 16, 2021
Merged
casperlabs-bors-ng bot
added a commit
that referenced
this issue
Sep 22, 2021
2081: Expand Deploy Acceptor r=darthsiroftardis a=darthsiroftardis
Co-authored-by: Ed Hastings <ed@casperlabs.io>
CHANGELOG:
- Expanded the checks the `DeployAcceptor` makes on a single `Deploy`
- Account related checks
1. Checks if the `AccountHashes` associated with the `Deploy` are valid associated keys
2. Checks if the `Weight` of the `AccountHashes` meet the threshold to perform a deployment
3. Checks if the balance of the `Account` in the case of a `Deploy` received by from a `Client` is sufficient
- ExecutableDeployItem
1. Checks if the ExecutableDeployItem present in the session or payment fields are valid and present in the case of stored contracts and contract packages
- Moved the cryptographic validity check of a `Deploy` to be the last step once all other prerequisites are met.
- Expanded the test suite to cover the newly added checks
Closes #2085
Co-authored-by: Karan Dhareshwar <karan@casperlabs.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A lot of the checks that EE does on deploys can be also performed in the deploy acceptor to reject the deploy earlier.
The text was updated successfully, but these errors were encountered: