Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid marking blocks complete prematurely while validating #3520

Closed
piotr-dziubecki opened this issue Dec 21, 2022 · 0 comments · Fixed by #3549
Closed

Avoid marking blocks complete prematurely while validating #3520

piotr-dziubecki opened this issue Dec 21, 2022 · 0 comments · Fixed by #3549
Assignees
Labels
release blocker PR to be merged before releasing

Comments

@piotr-dziubecki
Copy link

We need to ensure for a validating node that it doesn't mark a block complete immediately after executing it (as it doesn't have strict finality yet) and likewise it shouldn't notify the block accumulator at that point. Current idea is to handle that in the ReactorAnnouncement::CompletedBlock section of dispatch_event, and also to move the section under BlockAccumulatorAnnouncement::AcceptedNewBlock there too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release blocker PR to be merged before releasing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants